Petrik de Heus comments

Results 175 comments of


                                            Petrik de Heus

Fix override existing join types in the query in the `where.associated` method

@saleh-alhaddad It's clear you want to allow changing the join. It's not clear what would be the benefit. For example, your added test has the same results as not passing...

Fix override existing join types in the query in the `where.associated` method

@saleh-alhaddad please don’t ping commiters. Most are volunteers and contribute in their spare time. Hopefully someone will find the time to look at this PR.

[ruby/rack] Enable Rubys M:N thread scheduler for Puma

@NateBrady23 These are just waiting for a new run with the existing version, so we can compare if the PRs improve things.

Add `analyze` methods for getting metadata

It would be nice to add fastimage as an analyzer as well.

NoMethodError on Ruby 3.2 for `File.exists?`

Thanks @rocket-turtle !

add navbar highlighting to guides [ci skip]

This looks great!

add navbar highlighting to guides [ci skip]

On Firefox, if I scroll fast it doesn't seem to update: https://github.com/rails/rails/assets/28561/f9521c10-941c-45f4-a6e9-94f75ca7129a

[ci skip] Improve accessibility

Thanks for sticking with this @SleeplessByte ! It seems the side bar no longer scrolls when the nav highlight is outside the visible region: https://github.com/rails/rails/assets/28561/ca82b356-e8b7-4223-93a8-3c42b4b1ce40 I'm also getting the following...

[ci skip] Improve accessibility

Is the white text with red highlight maybe a bit too much in light mode? Current version: This PR:

[ci skip] Improve accessibility

> Yes, the scrolling of the sidebar (`scrollTo`, `scrollTop` etc), stops scrolling on Windows, which means that as you are scrolling the main element, and the side element is scrolled,...