foundation-rails icon indicating copy to clipboard operation
foundation-rails copied to clipboard

Fix build, add Rails 6 support, and update ruby versions

Open p8 opened this issue 4 years ago • 3 comments

Removes ruby 2.3.8 from the build matrix because it is end-of-life and fails with Rails 6.

p8 avatar Feb 25 '20 16:02 p8

Hi @p8 thanks for this...

I wanted to add Foundation to my Rails 6 app and was struggling (brand new to webpacker, not a front-end dev by any means).

Does your pull request fix it? If yes, is there any way for me to roll my own before it gets merged and included in the gem? (I'm also fairly new to open-source and github, so thanks for bearing with me)

Thanks!

bluemihai avatar Mar 26 '20 13:03 bluemihai

Hi @bluemihai,

You can reference my fork by using the following in your Gemfile:

gem 'foundation-rails', git: 'https://github.com/p8/foundation-rails.git', ref: '199beb3' # switch to sassc and fixes reveal animation

The "Rails 6 support" is for running the specs on this project. I'm running it on Rails 6 with sprockets...

p8 avatar Mar 26 '20 14:03 p8

Will this be merged in soon?

asadakbar avatar Oct 09 '20 21:10 asadakbar