Petrik de Heus

Results 175 comments of Petrik de Heus

I think we should revert the multicolumn implementation for now. There still are some things we have to workout like `{column}_filename_valid?` but there might be others. We can create a...

@lawso017 sorry for the late reply. You can probably fix this by setting the key in your factory. Which is probably more consistent with how things work with a real...

This happens because filename is overridden and it assumes fog is used: https://github.com/dwilkie/carrierwave_direct/blob/master/lib/carrierwave_direct/uploader.rb#L116

@lawso017 Sorry for the confusion, but 0.0.15 did have validations (https://github.com/dwilkie/carrierwave_direct/blob/v0.0.15/lib/carrierwave_direct/validations/active_model.rb). Things probably broke because of the multi column implementation. I agree we might want to turn off default validations...

Carrierwave-direct doesn't currently support creating an upload be setting the file on the model. It expects the attribute_key to be set and then it downloads the file from S3. For...

@kevinc This should be fixed with the following https://github.com/dwilkie/carrierwave_direct/pull/198

Thanks for the feedback! I'll see if I can make some changes.

Hey @colby-swandale, yes hopefully I can make some changes soon.

Hmm, I had the same issue but didn't think it had anything to do with `default` service name. `stop_system_service` should probably not be called when the service name is `default`....