mark9064

Results 285 comments of mark9064

I think we'd probably want to stick to one theme, as supporting multiple adds some extra overhead from a code maintenance perspective. I think it's nice that the colours are...

@JF002 Any chance you can chime in, I got interested in InfiniTime long after this colour was chosen so wondering if there's any history here (and therefore maybe reasons to...

Alright this a monster PR so review is going to be slow. It looks super cool though! To start, could you run the autoformatter and make sure your code follows...

Looks super cool! I think it's different enough to the Digital face that it should be its own one. Could you move the font to the external flash? That should...

Looks like your tree isn't doing so good :sweat_smile: It's always a good idea to look at the diff you have staged before committing, because you can check you haven't...

> I have no idea how I've done this, but I've accidentally added _A LOT_ of unnecessary files. OK, so the first thing to do is make a backup of...

No worries, whatever works :smile: Learning rebasing might be worth it though. Having a nice commit history makes review faster but it's not a must, most of the time I...

Should we change the default `---` since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)

If the ajira has "repository maintainers can edit this PR" or whatever the option is turned on, you should be able to (force) push directly to their branch IIRC. To...

This PR is definitely an improvement, thanks! Sorry for the slow review- the main reason is that this PR highlights a wider problem with the way access to the vibration...