mark9064
mark9064
Well in GetTimeRemaining it also multiplies by 1000 which will cause overflow. Basically all code paths involving it will need to be refactored to make sure they don't multiply tick...
> Yes. You mean the timer currently being limited to 59:59 right?
Also Scott if you'd like me to take a look at the overflow issue I'd be happy to - if so let me know exactly what you've tried so far...
Thanks for the detailed report. This is caused and fixed by #2108 which hopefully should be landing soon
Should be fixed now on main (and for the upcoming 1.15). Please do re-open/create a new issue if you still encounter problems!
Can you still repro with #2329 ? If so, try applying #2328 also
Great :) I don't know what part the magnet plays though, I guess it affects the accelerometer somehow?? Assuming that's the case (and that's a big assumption), my speculation is...
I've implemented this already but need to upstream it. Poke me after a while if I haven't yet :P
Thanks :) I've spotted a few things in my implementation that I want to clean up, but I'll try get it sorted soon. I've put this on the 1.17 milestone...
I don't love this conceptually as it kind of breaks the idea that the DirtyValue is a state container that informs of updates only on state changes. However, I'm not...