InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Remove leading zero for HRM value

Open tituscmd opened this issue 7 months ago • 6 comments

Hello everybody!

This is another simple PR of mine. This PR removes the leading before the BPM value in the Heart Rate app. Previously it would say "083", but now it looks like this: bpm I think this is cleaner than with the leading zero, but it might be up to preference.

Let me know what you think!

tituscmd avatar Jun 07 '25 14:06 tituscmd

Build size and comparison to main:

Section Size Difference
text 379204B 0B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu

github-actions[bot] avatar Jun 07 '25 14:06 github-actions[bot]

Should we change the default --- since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)

mark9064 avatar Jun 29 '25 23:06 mark9064

Should we change the default --- since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)

imageimage In my custom version of this UI, I also use two dashes instead of the three. The reason being that, most of the time, your heart rate will likely be double digit.

tituscmd avatar Jun 29 '25 23:06 tituscmd

Or just one? I think, I am fine with any of the variants.

minacode avatar Jul 03 '25 00:07 minacode

Or just one? I think, I am fine with any of the variants.

I think two digits "--" would be the most logical approach here, because that's the amount of digits your heart rate is going to be most of the time. If that makes sense to y'all, I could definitely open another PR to replace every 0 (in the context of heart rate) with "--"

tituscmd avatar Aug 25 '25 17:08 tituscmd

Okay, let's try two and get this merged! 🙂

minacode avatar Sep 27 '25 09:09 minacode