Remove leading zero for HRM value
Hello everybody!
This is another simple PR of mine.
This PR removes the leading before the BPM value in the Heart Rate app. Previously it would say "083", but now it looks like this:
I think this is cleaner than with the leading zero, but it might be up to preference.
Let me know what you think!
Build size and comparison to main:
| Section | Size | Difference |
|---|---|---|
| text | 379204B | 0B |
| data | 944B | 0B |
| bss | 22536B | 0B |
Should we change the default --- since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)
Should we change the default
---since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)
In my custom version of this UI, I also use two dashes instead of the three. The reason being that, most of the time, your heart rate will likely be double digit.
Or just one? I think, I am fine with any of the variants.
Or just one? I think, I am fine with any of the variants.
I think two digits "--" would be the most logical approach here, because that's the amount of digits your heart rate is going to be most of the time. If that makes sense to y'all, I could definitely open another PR to replace every 0 (in the context of heart rate) with "--"
Okay, let's try two and get this merged! 🙂