mark9064
mark9064
Great :)
Looking superb. Just needs a rebase for CI to run (and the last few bits of feedback) and then it's all good from me
Does this implement subscribing to service changes? I think this is probably required given the ANCS can come and go at any time I think the implementation of this is...
I don't believe it's handled elsewhere, but it could be? The text you quote at the top, about the service being registered/unregistered, isn't talking about bluetooth disconnects but actually the...
Not sure what's up with clang-tidy, unless there's a submodule update github isn't showing? Could you fix the code formatting?
You probably want to avoid using the legacy PWM layer, it's going to be removed in a future SDK version (in fact it already has AFAIK but InfiniTime hasn't upgraded...
Ah you've spotted and removed the legacy layer already - NW then What's the exact simulator error you get?
I think you'll probably want to do something similar to what's been done with other controllers e.g the brightness controller https://github.com/InfiniTimeOrg/InfiniSim/blob/main/sim/components/brightness/BrightnessController.cpp
If you look at some of the other controllers, they are reimplemented in InfiniSim. Have a look at one linked - see how the hardware specific code that isn't relevant...
I noticed this when implementing AOD. It's mostly transient image retention and disappears with time (a few minutes) - try toggling the the flashlight app for a bit and the...