InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Dark App Launcher Tiles

Open tituscmd opened this issue 7 months ago • 6 comments

This is a simple PR to replace the aqua colored tiles in the app launcher with darker ones, going hand-in-hand with my #2292 This is most likely just up to taste, but I thought the cyan tiles were outdated since that color isn't used anywhere else, so I thought a darker color would match the current system theme better.

Let me know what you think!

image image image

tituscmd avatar May 12 '25 18:05 tituscmd

Build size and comparison to main:

Section Size Difference
text 378980B -16B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu

github-actions[bot] avatar May 12 '25 18:05 github-actions[bot]

The issue I see with this is it's a matter of preference: some people may prefer the aqua, and some may prefer this gray.

I'm not sure if this would align with the vision, but a setting to change the theme would be nice, with options for the original color, this gray, maybe a red, and so on.

liamcharger avatar May 12 '25 18:05 liamcharger

I think we'd probably want to stick to one theme, as supporting multiple adds some extra overhead from a code maintenance perspective.

I think it's nice that the colours are synchronised, though I don't feel super strongly

mark9064 avatar May 12 '25 22:05 mark9064

As I found out in #2301 , the application launcher does track an enabled state for the app icons (for when the resources are missing for example).

So nothing against changing the color, just mentioning that is should probably still allow seeing a disabled app icon.

mmind avatar May 27 '25 08:05 mmind

@JF002 Any chance you can chime in, I got interested in InfiniTime long after this colour was chosen so wondering if there's any history here (and therefore maybe reasons to change/not to change it)

mark9064 avatar May 30 '25 22:05 mark9064

I'm not sure I remember how this specific color was chosen, to be honest. We used to have maintainers who took care of the UI (themes, colors, layout,..) but they are not around anymore. I think there's no reason not to change it, especially if it improves the user experience and consistency between all InfiniTime applications.

JF002 avatar May 31 '25 19:05 JF002

I agree that using the theme here is the correct way to go. Changing the theme would be another discussion.

minacode avatar Jun 29 '25 15:06 minacode

Thank you! 🙂

minacode avatar Jun 29 '25 15:06 minacode

Thank you! 🙂

You're very welcome! :)

tituscmd avatar Jun 29 '25 15:06 tituscmd