Chen Liang

Results 625 comments of Chen Liang

I think we are looking for 25. There is no point of internal use in java.base, but it might help other modules. For the specific issue you've linked, I think...

Ideally we would use something like a preview note, but this is now turned into [a JEP](https://openjdk.org/jeps/8363700) so a stopgap measure is better.

Since this is an API addition, this will require a CSR. Once we have settled with the javadocs, I can create a CSR (which requires a JBS account)

I have created the CSR. @asotona might help review it; but the CSR review lead will be on winter break, so you might need to wait till January.

I have one question: would it be safer for us to move the constant detection after generate_virtual_guard in the `is_virtual` if block? I think it may be possible for users...

I tried to come up with an example where the buggy code from Vladimir would inline to identityHashCode when the right call would be virtual - couldn't construct such a...

For StringBuf proxy, is it acceptible for us to introduce a new jdk.internal public interface (accessible only within java.base module) to expose common public methods in AbstractStringBuilder? We have public...

> Hi @liach Do you know any other places within java.base where we would need the same proxy for StringBuffer? Good question! I looked at https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/class-use/StringBuffer.html. I think such a...