Chen Liang comments

Results 625 comments of


                                            Chen Liang

8367792: [lworld] Remove the Unsafe remnants of old valhalla prototypes

Hi @jatin-bhateja, as I know, the larval bit is completely unused in current Valhalla - I believe what we should do with that assert is to simply remove it. I...

8338544: Dedicated Array class descriptor implementation

I know this requires a CSR; it's just not created due to this still being a draft. The main purpose of this is still for speeding up stack map generation;...

8338544: Dedicated Array class descriptor implementation

Confirmed this is performance-wise neutral for startup. Ready for review.

8338544: Dedicated Array class descriptor implementation

@JornVernee I have updated the implementation class name and the factories for clarity.

8338544: Dedicated Array class descriptor implementation

Thanks for the reviews; can anyone review the associated CSR at https://bugs.openjdk.org/browse/JDK-8340963 as well?

8338544: Dedicated Array class descriptor implementation

Just noticed that the `ArrayClassDesc::displayName` was buggy - existing tests had no coverage and I have added test coverage for `displayName` and a few other missed methods.

8338544: Dedicated Array class descriptor implementation

Thanks for the reviews! /integrate

8306039: ParameterizedType.getOwnerType() documentation is incomplete about null result

Keep-alive.

8306039: ParameterizedType.getOwnerType() documentation is incomplete about null result

/open

8306039: ParameterizedType.getOwnerType() documentation is incomplete about null result

/label add compiler cc'ing this to the javac list: this brings in a few definitions from the JLS to core reflection, for which the compiler developers know better.