Chen Liang comments

Results 625 comments of


                                            Chen Liang

8342469: Improve API documentation for java.lang.classfile.instruction

Thanks for the reviews! /integrate

8342469: Improve API documentation for java.lang.classfile.instruction

/backport :jdk24

Document IAE for Unsafe offset methods

For arrayBaseOffset/IndexScale, I don't think I will change it here: they are methods that are exposed via sun.misc.Unsafe.

Document IAE for Unsafe offset methods

Thanks for this permission to update the Atomic updaters. I found that there's no coverage in tck when these IAE on static fields are acknowledged recently, so I took the...

Document IAE for Unsafe offset methods

I have added test cases to verify the current behaviors of Atomic field updaters and Unsafe memory address calculation methods, including untouched ones for arrays pointed out by @ExE-Boss. All...

Document IAE for Unsafe offset methods

I think from our discussions, there is nothing else to change for this patch. Please correct me if my understanding is wrong, and if it isn't, I hope someone can...

Document IAE for Unsafe offset methods

@vy Can you help review this patch too? For context, `objectFieldOffset(Class, String)` should only find trusted fields and is a bootstrap optimization, while the Field-accepting version is the generic API.

Document IAE for Unsafe offset methods

Thanks for the reviews. As a final note, I decide to keep the in C++ unsafe checks for now; the unsafe.cpp seems to indicate there are more contracts that I...

8356548: Avoid using ASM to parse latest class files in tests

Testing: hs-tier 1-5

8356548: Avoid using ASM to parse latest class files in tests

/open