Chen Liang

Results 625 comments of Chen Liang

I just noticed there is `LibraryCallKit::inline_string_getCharsU` that is for byte -> char conversion. I wonder if we can slightly update it for char -> byte conversion.

I consulted @rose00 - Intrinsics are costly, so a next step might be removing the intrinsic for `toBytes` (which allocates a new byte array, unsuitable for here) and `getChars` in...

Can't we just always stick to mixin config plugins for conditional application? This is what sponge has been always doing. Need to take a stance on this and decide whether...

/label add i18n As promising as the performance number is, I think we need to ensure two things: 1. Correctness: this patch adds a lot of special cases; not sure...

As complex as this optimization may appear, I think we can probably consider breaking it into more maintainable parts: 1. Reducing appendable allocation if we just format to formatter once...

For classes, for now you can probably mixin to like the static `CatEntity.createCatAttributes` etc and call `add` on the return value of the method, etc. Should you do it by...

@jiafu1115 Should this regard different types of splitters? Or add some method like `ignoreExtraSeparator()`?

There must be a reason why it throws an exception when detecting more than one separators. You should ping a project manager.

I think we need to ping the authors of `Splitter`. @lowasser

A great cleanup that consolidates scale2, unscaledAbsString, and unscaledString.