8341272: Factory to create wide iinc instruction with small arguments

[trevorkbond]

Add a new factory method to IncrementInstruction that allows the explicit creation of a wide iinc instruction, even with a slot and constant that could fit into a normal iinc instruction. Previously, only one factory for iinc instructions existed, which inferred the type of instruction needed given the size of slot and constant. Add additional test cases for the new factory as well. All tier 1 tests and classfile tests have passed with these changes.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] Change requires CSR request JDK-8373709 to be approved

Issues

• JDK-8341272: Factory to create wide iinc instruction with small arguments (Enhancement - P4)
• JDK-8373709: Factory to create wide iinc instruction with small arguments (CSR)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28729/head:pull/28729
$ git checkout pull/28729

Update a local copy of the PR:
$ git checkout pull/28729
$ git pull https://git.openjdk.org/jdk.git pull/28729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28729

View PR using the GUI difftool:
$ git pr show -t 28729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28729.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back trevorkbond! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

@trevorkbond The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (44612c5f)
• 00: Full (4acc5b44)

[liach]

Since this is an API addition, this will require a CSR. Once we have settled with the javadocs, I can create a CSR (which requires a JBS account)

[trevorkbond]

Thank you for your comments and review. I have made some changes that should address those.

[asotona]

/csr needed

[openjdk[bot]]

@asotona has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@trevorkbond please create a CSR request for issue JDK-8341272 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[trevorkbond]

Hi @liach, would you be able to create a CSR request, or is there anything you need from me here? Thank you

[liach]

I have created the CSR. @asotona might help review it; but the CSR review lead will be on winter break, so you might need to wait till January.