Chen Liang comments

Results 625 comments of


                                            Chen Liang

8356548: Avoid using ASM to parse latest class files in tests

Circled back and renamed confusing variables in this patch.

8356548: Avoid using ASM to parse latest class files in tests

Ran tier 1-6 and saw no related failure. Should I wait for another reviewer?

8356548: Avoid using ASM to parse latest class files in tests

Thanks for the reviews! This should remove the hassles associated with new javac class files from value objects in the future. Integrating. /integrate

8342206: Convenience method to check if a ClassEntry matches a ClassDesc

> I think it might be a good idea to also have `equalsSymbol(…)` methods for the other pool entries. Indeed, this can avoid promotion to String state for all applicable...

8357289: Break down the String constructor into smaller methods

I think the main advantage here is that with smaller, static methods, it allows us to merge these replacement-decode methods with the no-replacement-decode methods. This is already how the encoding...

8357289: Break down the String constructor into smaller methods

For startup time, I believe this should have little impact: String itself, without allocation of its storage array, should be as expensive as generic record objects. This should have similar...

8342650: Move getChars to DecimalDigits

I think the fix is easy: Unsafe calls are using a bad offset which should be cast to long. Will submit a PR, but since I cannot reproduce the original...

8335645: j.u.Formatter#trailingZeros improved with String repeat

See https://openjdk.org/guide/#life-of-a-pr point 6 for the 24-hour wait rule.

8335645: j.u.Formatter#trailingZeros improved with String repeat

/sponsor

8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory

This might be helpful combined with #21730.