Chen Liang

Results 625 comments of Chen Liang

Can we make a "sinces" file that is updated with each yarn version? So when elements are lost, they are lost in the since file; otherwise, the new ones are...

If we have such a UID system, tracking initial versions are naturally easy as we can add that as one of the data associated to each UID. For now, my...

We for sure should not allow upper snake case for non-final fields as they can be set to a new value.

lol no, the convention is based on field access modifier than it's behavior.

Is this image good license-wise? I am afraid. Maybe add a `width="25"` in the img tag might help. > can you change the image based on light/dark?… Yes. It's already...

@haykam821 What do you suggest to do with oversized icon? Put it as separate image on top or make it sized like a small icon in my suggestion?

In the javadoc gen, we use the namespace names from the `.tiny` file. If we change, I think we should start from the tiny files. > Add something to the...

is this still applicable after mojang's recent revamp on screen handlers in like 21w11a?

Both `ReadOnlyChunk` and `LockableChunk` is problematic: This type is explicitly used in `ChunkHolder.setCompletedChunk`. The boolean field is final, and is `true` for regeneration and `false` for regular world gen; this...

Hmm, what are we supposed to do? Fyi for all constants, javadoc will generate a link to their corresponding value in the constant values page. So if a specific value...