jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8373552: ExactConversionsSupport: bad JLS links in javadoc

Open biboudis opened this issue 1 month ago • 5 comments

Add relative links to the spec URL of primitive-types-in-patterns-instanceof-switch-jls.html


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8373552: ExactConversionsSupport: bad JLS links in javadoc (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28775/head:pull/28775
$ git checkout pull/28775

Update a local copy of the PR:
$ git checkout pull/28775
$ git pull https://git.openjdk.org/jdk.git pull/28775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28775

View PR using the GUI difftool:
$ git pr show -t 28775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28775.diff

Using Webrev

Link to Webrev Comment

biboudis avatar Dec 11 '25 20:12 biboudis

:wave: Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Dec 11 '25 20:12 bridgekeeper[bot]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373552: ExactConversionsSupport: bad JLS links in javadoc

Reviewed-by: liach, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

  • 76e79dbb3eca5589aae6852c8f55adf0759c714e: 8371716: C2: Phi node fails Value()'s verification when speculative types clash
  • 89e77512fd44b6a0299ab36db15142e7544899f3: 8370922: Template Framework Library: Float16 type and operations
  • a61394b1da40cfbb617fec35553da2d3c3e27d37: 8373789: No PCH release build failure after JDK-8372543
  • ... and 53 more: https://git.openjdk.org/jdk/compare/66d7b0ce8f8414c3d5fd3476b65152b9f2a9a587...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Dec 11 '25 20:12 openjdk[bot]

@biboudis The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Dec 11 '25 20:12 openjdk[bot]

Webrevs

mlbridge[bot] avatar Dec 11 '25 21:12 mlbridge[bot]

Ideally we would use something like a preview note, but this is now turned into a JEP so a stopgap measure is better.

liach avatar Dec 15 '25 20:12 liach

/integrate

biboudis avatar Dec 17 '25 10:12 biboudis

Going to push as commit 9a23f8aa337e1292179625ce9bb8abe22c9e22e2. Since your change was applied there have been 75 commits pushed to the master branch:

  • fc76403b01c4e801f2a58810deeec2a6ebfa8458: 8373798: Refactor java/math tests to use JUnit
  • af18fbd42d2a437dd35f33e557a8906ca0c3bd07: 8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java
  • 4924b29fa519996b806ac0f4a7c898085f44bc4c: 8370655: Check EINTR handling InetAddress implementation and NET_ThrowNew
  • ... and 72 more: https://git.openjdk.org/jdk/compare/66d7b0ce8f8414c3d5fd3476b65152b9f2a9a587...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Dec 17 '25 10:12 openjdk[bot]

@biboudis Pushed as commit 9a23f8aa337e1292179625ce9bb8abe22c9e22e2.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Dec 17 '25 10:12 openjdk[bot]