Chen Liang
Chen Liang
Given the nature of vanilla's entity data tracker system (dependence on hierarchy), I strongly oppose reusing the vanilla system. Fabric can just make another type of packet channel to communicate...
Also for packet, `fabric` namespace is bad: should be the mod id of the specific implementation mod. `private/` prefix is unnecessary too. I suggest add like `/v1` suffix etc so...
I have looked at the CSR and revised the wording for you, mostly conveying information CSR review wants to see. The original "Problem" section only mentions performance, but I added...
Wiki pages such as https://wiki.openjdk.org/display/csr/Fields+of+a+CSR+Request are good starting points for CSRs. CSR review will look at CSRs listed at https://bugs.openjdk.org/secure/Dashboard.jspa?selectPageId=17313. To finalize a CSR for review, you should set your...
> @liach Just to make it clear: Thumbs up for "current code _is_ more understandible" or thumbs up for "undo last commit"? 🤔 My thumb up is for this: >...
/reviewers 2 committer
/jep jep-486 @seanjmullan I think you can use many lines of command in one github comment, like ``` /contributor add @seanjmullan /contributor add @AlanBateman /contributor add @wangweij /contributor add @AlekseiEfimov...
Looking to integrate this as I have added all functionalities in the RFE (despite the ctor call relocation being extremely primitive) /integrate