Keenan Brock

Results 228 comments of Keenan Brock

@fryguy Since `EventCatcher` is uses often and in longer names, reducing that buys us a lot. On the other hand, `EventHandler` is only used once at the top level. leaving...

- I want to changing both `worker_deployment_name` and `abbreviated_class_name`. - `worker_deployment_names` are currently too long for OpenShift - I want `worker_deployment_name` to be based upon `minimal_class_name` (and subsequently `abbreviated_class_name` --...

| old deployment name | new deployment name |:---|:---| | 35r24369-amazon-agent-coordinator | 35r24369-amazon-agent-coordinator | | 35r24369-amazon-cloud-manager-event-catcher- | 35r24369-amazon-cloud-events- | | 35r24369-amazon-cloud-manager-metrics-collector | 35r24369-amazon-cloud-metrics | | 35r24369-amazon-cloud-manager-refresh- | 35r24369-amazon-cloud-refresh- | |...

- The specs set the `ems_id`. Not sure why they do not show up in the puts/values. - would prefer not changing the systemd value. Would also prefer not having...

@chrisarcand If we change `ORDER BY lower(name)` to just `ORDER BY name` the function, does this resolve this issue?

so this error happens when the order is not in the select clause. even thought the `name` is in the `SELECT` clause, it needs `lower(name)` to be in the distinct...

WIP: wanted this as a conversation before saying to merge it

> For now we should merge this to fix the internationalization bug. Separately we can figure out if this should use lambda syntax. Ok, that sounds like you understand the...

anyone know what the issue is here? ``` ⚠️ - Line 85, Col 10 - Lint/LiteralAsCondition - Literal /true/i appeared as a condition. ⚠️ - Line 87, Col 10 -...

update: - removed regular expression PR that is already merged into master via https://github.com/ManageIQ/manageiq/pull/21669