Keenan Brock

Results 228 comments of Keenan Brock

Hey you -- Mr. Tender Love Making, Thanks for making dumb projects like this. Tender > a person who looks after someone else or a machine or place: Alexei signaled...

> I don't think we need to do any regexes phew. Because regexes and yea. regexes. https://xkcd.com/1171/

This seems to be working in chrome 36 for me. can this issue be closed?

Great PR - a little on the big side, though. @carlosgaldino do you like the idea of using `JSON` instead of a ruby hash? Maybe split up the PR a...

I could have sworn this was fixed. Either way, would be really nice to just delete `use_config_for_attributes` and have this work as normal

@Fryguy do we still need to support `::Settings.server.company` or `Settings.server.custom_login_text`? These are part of the tenant but have overrides in `settings.yml`. company name has a default value but custom login...

### Goal remove logic for `use_config_for_attributes: i.e.: https://github.com/ManageIQ/manageiq/blob/master/app/models/tenant.rb#L336-L343 ### Current - The administrator can set the company name in `settings.yml`. It is accessible via `::Settings.server.company` - The administrator alternatively can...

>What would be the migration for existing installations? We would just stop using the value in `Settings.yml`. >Is API considered here as well? I think /api currently has this information...

yea. the only real use case I know about was 2 different regions used a different LDAP server and they wanted to change the messaging on the login server to...

WIP: - left debug code for before / after - left comments so others can play around with the code if desired