opendbc
opendbc copied to clipboard
Honda: CANFD long control
Adding long control for Honda CANFD models.
Based on PR2162, rebaseling to current opendbc codebase, with addition of safety code.
Defer long tuning to future PR.
Todo:
- [x] rebaseline on latest code
- [ ] Test with panda fix to see if it can prevent startup faults on quick restarts
- [ ] Likely need to add many new fingerprints with panda fix
- [ ] See if BRAKE_ERROR can be made global/common, it's present in a Nidec DBC as well
- [ ] #2638
- [ ] Drive testing
- [ ] Why does it fault on quick restarts?
- Does comma3+red panda usage require bus 4 as written?
That's not necessary, each Panda only knows about what it's hooked up to.
- This makes startup faults temporary as car does this if engine is restarted too soon after shutdown. Is there another way to buffer flush at shutdown to prevent?
Will have to look and see what's broken.
- [ ] Why does it fault on quick restarts?
This could be connected to #2632. Not saying it is for sure, but Panda is dealing with a disruption that can back up queues and affect other buses as well, so I wouldn't spend a bunch more time on it until that's been resolved.