Josh Black
Josh Black
Sure thing @cs25-esc! I added some additional information, this is purely a TypeScript change that would be resolved by updating the types used so that a string or number is...
Sure thing @kudah99! Let me know if I can help or provide assistance in any way 😄
Hey you two! Just wanted to double-check with you all if this would be a good one to include or defer for v36 👀 cc @siddharthkp @colebemis
Cherry picked over into: https://github.com/primer/react/pull/4960 to make it easier to merge 👍
Verified analytics are being sent for the preview over in: https://github.slack.com/archives/C02NUUQ9C30/p1714755458846759?thread_ts=1714728330.477579&cid=C02NUUQ9C30 Updated it so that we now will only report in production and **not** previews 👍
Following up, this fails downstream tests suite typically with an `act()` violation error 🤔 So it may be that this change is causing effects to happen where they do not...
Thanks for making this issue @maximedegreve! Just wanted to leave a note that I believe the "ActionMenu positioning" section has a corresponding issue over at: https://github.com/primer/react/issues/4059
From an implementation perspective, I think this could follow a similar flow to VRT where we basically build up things like storybook and the docs and pass those along to...
Hi all! 👋 Just wanted to check-in to see if this issue is still relevant and close it, if not 👀
cc @vpicone