react
react copied to clipboard
Add back in support for `string | number` for `id` of items in `Autocomplete`
In v36, this type was narrowed to be a string
. We should broaden this type back to the original to be string | number
This type is defined by the items
prop in AutocompleteMenuInternalProps
, where each item extends AutocompletItemProps
. This type extends AutocompleteMenuItem
which creates an association between Autocomplete
and ActionList
, specifically ActionListItemProps
, which is what specifies id
as string
.
This issue is responsible for broadening the type to string | number
instead of purely a string
.
hi @joshblack can you elaborate the issue and could you please share any url and photo to check the same. Thanks
Sure thing @cs25-esc! I added some additional information, this is purely a TypeScript change that would be resolved by updating the types used so that a string or number is accepted for the id
field.
Hope this makes sense! Let me know if you have any questions
@joshblack can i take on this issue
Sure thing @kudah99! Let me know if I can help or provide assistance in any way 😄
Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.