Focus Zone, ArrowVertical does not take into account input elements that have step defined

[1951FDG]

For ArrowVertical does not take into account input elements of type "number" that have step defined, meaning it overrides the default behaviour making stepping with up and down key no longer working.

I think this can be fixable by adding some code to: https://github.com/primer/behaviors/blob/92e06b516eb3751bcf864c3678fd2722df885f4f/src/focus-zone.ts#L261

[siddharthkp]

Hi!

Thanks for taking the time to report this, do you mind creating adding a reproduction of the issue on codesandbox.io or stackblitz.com?

[1951FDG]

Hi!

I hope this helps, since I don't have either

https://jsfiddle.net/2j6nr01x/

[1951FDG]

So to have stepping of the number input working again with up and down arrow key, remove FocusKeys.ArrowVertical

[lesliecdubs]

@camertron is going to take a quick look to see if we can validate this bug by looking at the test suite and we can go from there.

[camertron]

Hey @1951FDG, I'm not sure what you mean by "remove FocusKeys.ArrowVertical." However I think you were correct to identify shouldIgnoreFocusHandling as the place to make the change. Can you try adding the following code to the end of that function?

if (activeElement instanceof HTMLInputElement && activeElement.type === 'number') {
  return true
}

[1951FDG]

Hey @camertron, cool, I'll look into this as soon as I'm back next year, and maybe submit a pull request for it to be reviewed.

[joshblack]

Hi all! 👋 Just wanted to check-in to see if this issue is still relevant and close it, if not 👀

[1951FDG]

Hi there, if I make the necessary changes, and submit a pull-request, will it be merged, or are these changes to be made on a per use case.

[keithamus]

PRs are always welcome, provided there is a motivating use case and the code is clean and well tested 👍

[github-actions[bot]]

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.