primer
feat: add experimental Label component
[!NOTE] This is a part of our weekly mob programming session 👀
Token -> Label
AvatarToken -> Label w/ leading visual prop
IssueLabelToken -> IssueLabel
⚠️ No Changeset found
Latest commit: 2fe79e6f0d2d9a06b7b27a1278a9c353b854b2e1
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 97.11 KB (-0.05% 🔽) |
| packages/react/dist/browser.umd.js | 97.42 KB (+0.03% 🔺) |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey, I am a bit concern with the name Label. A label is different from what we want. The correct name would be IssueLabel, can we rename it?
Notes for next pair session:
- Using this as a reference https://github.com/github/github/blob/1f7d3bba98e3d62a150a57ce4f72f4ec8631c018/ui/packages/label-token/LabelToken.tsx#L35
- We agreed to keep color2k
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
Cherry picked over into: https://github.com/primer/react/pull/4960 to make it easier to merge 👍