Josh Black

Results 176 comments of Josh Black

Closing this PR out, hope that's okay @khiga8! Happy to re-open if not 👍

Great point @khiga8, I guess with elements that have a Shadow DOM the utility we're using won't pull out their text content 🤔 I feel like we could go down...

Hi there @HDinger! Tried to see how to get everything passing CI wise and I think for this project we needed a PR from a maintainer for the snapshots to...

Closing this one out as we cherry picked the commit over into: https://github.com/primer/view_components/pull/3253 so that the snapshots would generate. Thanks so much for contributing this! Let me know if you...

## API Design ```jsx // Sample code snippet ``` **Props** | Name | Type | Description | | :--- | :---- | :---- | **Links & Resources** - https://www.radix-ui.com/docs/primitives/components/tabs -...

Question, how would we relate switchers like in this example: ![image](https://user-images.githubusercontent.com/3901764/132385506-abc02550-7363-4175-9ace-f14b9f5d6ae5.png)

ContentSwitcher checklist - [x] Click should change panels - [ ] Tab support - [x] Manual - [x] Automatic - [ ] Disabled ??? CAG - [ ] Programmatic API...

**Next steps** - Take this to design, we would like to get alignment on this component - This component seems to be used for several situations, including: - A toggle...

> Should we rename expand with something else I'd love to try and come up with a descriptive name but it's definitely challenging 🤔 Maybe we could use `NavList.ShowMoreItem` to...

Going to remove myself as a reviewer from this since it seems like you're testing this out 👀 Let me know if not and I can re-add myself!