Josh Black

Results 176 comments of Josh Black

@siddharthkp would love to do something like `PrimerApp` or some kind of "App-level" component like what you described 👍 it would make it simple to add in things as "defaults"...

Hi there! 👋 Just following up, since we haven't heard back in two weeks I'm going to close this one out. Feel free to leave a comment and we can...

@siddharthkp for reviewing, should I be looking at the semantics of the nested selection story or should I be just looking at the back button behavior? Seeing the initial listbox...

Hi there @tmelliottjr! Thanks for taking the time to make the issue 🙏 When going through this during issue triage, we could totally confirm the issue and we added it...

@mperrotti just a heads up, started the API PR over in: https://github.com/github/primer/pull/2958 based on our conversation before break! Let me know if I missed anything in the API block and...

Note: looking into the deploy preview problem now to see what we can do. Unfortunately we directly wire things up to `@primer/react` from docs so the node export conditions aren't...

@mperrotti thanks so much for the review! Appreciate it a ton. Will respond to some of the questions below 👇 > When would I use ? Hopefully never 😅 This...

One quick update, the `Status` component has been updated after some feedback. This component, along with a new `Alert` component, now announce their contents instead of a dedicated `message` prop....

Closing as this work has moved out into: https://github.com/primer/live-region-element https://github.com/primer/react/pull/4313