Josh Black
Josh Black
@colebemis good call on adding that individual test for tree shaking, it seems like `React.Fragment` is not considered pure (even when used in a pure `React.createElement` call) and is causing...
**Notes** - Can we be smarter about how we target dvh so that it works on iOS/iPadOS? - `@supports (-webkit-touch-callout: none) { }` is specific to mobile safari - Can...
Added a quick check for the touch-callout property and should be good to go!
@chrisconnors-ibm one thing we should call out is that the library can be updated, it's just a manual process without the tooling in place. Currently, I'm taking a look at...
cc @jeanservaas @aagonzales curious what you all think the next steps should be here, or if we should meet together to talk about this and figure it out together 👀
Hi there, @DavidC123! 👋 I believe that the `OverflowMenu` component uses the roving tabindex pattern due to the requirements detailed in Keyboard Navigation: https://w3c.github.io/aria-practices/#keyboard-interaction-12 As a result, you would use...
Thanks, @DavidC123! So sorry I misread that, you're totally right. I really appreciate you clarifying, it helped a ton!
@tw15egan definitely makes sense to me if we want overflow to go over side-nav 👍 However, I'm surprised that there would be an overflow menu _inside_ of the side nav...
bump @tw15egan is there a good action item for this issue?
@colebemis love these questions 🔥 > Should we add documentation for the script prop in the Theming section of the Primer React docs? Definitely 👍 > Will the SSR approaches...