Josh Black
Josh Black
If it's helpful, can use the GitHub Review UI to make comments on certain lines 👍 https://help.github.com/articles/about-pull-request-reviews/ talks about it a bit
Hmm, seems like we're missing the styles for this responsive prop 🤔 @langermank did we just miss these or were the lost during the transition/renames? 😅
Hey @Adarsha186! Thanks so much for offering to help! This had a PR open over at #4591 but just wanted to say that if there are any other issues that...
Note: the test failure is related to a deprecation notice that (I believe) is caused by an upstream dependency (in this case testing-library). Will make sure that's updated before moving...
Closing in favor of: https://github.com/primer/react/pull/4646
bump @langermank when you get a sec 👀
@lukasoppermann when you have a sec, could you add a changeset as a patch that talks about the changes to the CSS Custom Properties used? Thanks!
Since teams can customize the menus themselves, this could get a little weird. We have a `ClickListener` and `InnerClickListener` component that we can use here over from `carbon-components-react` https://github.com/carbon-design-system/carbon-components-react/blob/master/src/internal/ClickListener.js Seems...
@lesliecdubs happy to revive this! It should be good to go, just needs a review 👀 One question this does bring up is if we want to continue supporting this...
@lesliecdubs hopefully not much 🤞 And sounds good to me! 👍