Josh Black
Josh Black
Hi all! 👋 Just wanted to leave a comment to check-in and see if this issue was still present and, if not, to close out this issue.
cc @vpicone have you all run into anything like this on the Plex side?
Hi there! 👋 Just wanted to say thanks again for the taking the time to work on this, we picked it up and are building on it over in: https://github.com/primer/react/pull/3410...
bump @pksjce if you have a sec to review!
bump @siddharthkp when you have a sec!
@siddharthkp I think the notable thing is that we had these folders in place for when TypeScript didn't fully support the `"exports"` config in `package.json`. The linked issue in the...
@lesliecdubs definitely! Here's one: Basically the underline nav needs to have all items except the first one truncated to get it to happen.
Depends on: https://github.com/primer/react/pull/4263
I think one downside of this technique that wouldn't exist if using ternaries or refactoring into smaller components is that things are evaluated even if the condition is false-y. So...
Oh wait, is this file here now: https://github.com/primer/react/blob/main/packages/react/CHANGELOG.md ? Next to the package