Jon Atack
Jon Atack
I've opened a full revert in #1674 to provide a clean slate. Any desirable changes from this pull can be proposed separately.
Review and testing-under-way ACK 868413340f8d6058d74186b65ac3498d6b7f254a As described in the pull description, this value was set in 2017 in #10148 and hasn't been changed since. > Maybe a config option can...
Somehow I hadn't seen this PR yet. If I understand correctly, this change is only for if a node is configured with `-i2pacceptincoming=0` to not accept inbound I2P connections?
> I'm a bit reluctant to have this merged while BIP54 is in limbo (https://github.com/bitcoin/bips/pull/1800). BIP54 draft merged.
Review ACK 1e415d2cb703fcd1b622e5343fa264425601c8d modulo CI fixup Happy to see these methods see an update. I tried adding `EXCLUSIVE_LOCKS_REQUIRED(!m_nodes_mutex)` to the declarations, but it looks like that lock is already held...
ACK cc8f239663a0874c307efa30815b40d9ef40badb
Might be good to add a changelog in this pull, as previously in #1600.
Tend to suggest this PR be closed per discussions above (e.g. among others in https://github.com/bitcoin/bips/pull/1787#pullrequestreview-2692740268 and https://github.com/bitcoin/bips/pull/1787#discussion_r1991802274) as out-of-scope, perhaps technically unsound, and not proposed beforehand on the bitcoin-dev mailing...
Hi @GobiShanthan, are you still working on this? If not, feel free to close it.
cc @jamesob for feedback