bitcoin
BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity
Reloading this PR with minimal, backward-compatible changes.
- I believe there is consensus on the need to add a new champion here.
- The reason for adding a new reference implementation is to support Python 3.x with a thoroughly unit-tested implementation. I was unable to get the original Python 2.x reference implementation to run.
- [ ] If desired I can email bitcoin dev for more thoughts on these changes
could you possibly split this into "b64 entropy fix only PR" and "the rest" ?
could you possibly split this into "b64 entropy fix only PR" and "the rest" ?
Yeah~~but I’d also include the BIP32 comment because it’s a fact~~.
Can you also provide an explanation of the Base64 entropy fix in the commit message.
@jonatack this is my bug when I was adding base64 app to the BIP, seems it went unnoticed for long time...
Can you also provide an explanation of the Base64 entropy fix in the commit message.
@jonatack this is my bug when I was adding base64 app to the BIP, seems it went unnoticed for long time...
Here's the standalone fix: https://github.com/bitcoin/bips/pull/1683
Did you want to make the changes in the abstract and definitions sections that you did in https://github.com/bitcoin/bips/pull/1600?
I want to ~~but not in this changeset. Let's get through the hard parts then we can optimize on top of that. I'm tryna keep the changesets as small as possible for now.~~
In retrospect this basically nets out to a revert of the backwards incompatible part of #1600, reverted in #1674. These lines.
@jonatack thanks for the careful reviews. i think we're g2g. do committers squash and merge? if not should i rebase this? I was asked to preface all commits with BIP-85, and these commits are all orthogonal and semantic, but I personally would prefer a rebase because a lot of this is TMI for master, agree?