John Blackbourn

Results 494 comments of John Blackbourn

The return value in core is `WP_List_Table|false`. That doesn't strictly mean that `$class_name` must be `class-string`, but I agree that it's implied. And if you're doing something else then you...

I'm planning on switching to proper meta capabilities (which will map to `manage_options` by default) which you can then grant, deny, or filter to your liking. No ETA just yet...

Thanks for the issue. I'll do some testing!

> False is not necessarily an error condition - it can be false if the save was unnecessary This is true, but in the case of `force_schedule_single_event()` the save is...

@richtabor What do you think about adding a new post type label as mentioned above?

I disagree that adding a new post type label is overkill, their purpose is to allow post types to provide accurate labels that read clearly and can be well translated....

@jrfnl If you'd like to give this the nod then I'll get it in.

Ah we still need to verify that [WP Parser](https://github.com/WordPress/phpdoc-parser) handles this change ok so the developer.wordpress.org site can still be generated correctly. I'll test it.

Okay I finally got WP-Parser running locally on a PHP 7.4 container, at least enough to get it to parse the source and populate the parsed data. It looks to...

@narenin Thanks for the PR. `int` isn't a valid type in JSON schema.