wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Fixed schema for global styles REST API endpoint `wp/v2/global-styles/{id}`

Open narenin opened this issue 1 year ago • 6 comments

Trac ticket: https://core.trac.wordpress.org/ticket/61911


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

narenin avatar Aug 23 '24 05:08 narenin

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props narenin, johnbillion, timothyblynjacobs, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Aug 23 '24 05:08 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Aug 23 '24 06:08 github-actions[bot]

@narenin Thanks for the PR. int isn't a valid type in JSON schema.

johnbillion avatar Aug 24 '24 21:08 johnbillion

@johnbillion Thanks for the review, I have updated the same to integer, please check.

narenin avatar Aug 25 '24 02:08 narenin

This is slightly weird because the value does have a sanitize_callback registered for it which calls urldecode, which seems like an indication that the value is supposed to be a string. Are we sure this is supposed to be an integer? If so, we should probably also be removing the sanitize_callback.


We'd probably also want to update the regex to use \d+ instead of \w-


Sneaky edit 2, yeah it's definitely expecting a post id. So yeah I think this conceptually makes sense, we just need to make a few more changes.

TimothyBJacobs avatar Sep 17 '24 22:09 TimothyBJacobs

Thanks @johnbillion @TimothyBJacobs for your feedback's, I have implemented the same, could you please take a look.

narenin avatar Sep 18 '24 04:09 narenin

@johnbillion @TimothyBJacobs are you available to review the edited PR? Thanks!

audrasjb avatar Feb 10 '25 20:02 audrasjb

@narenin Want to take a look at these failing unit tests?

johnbillion avatar Feb 21 '25 15:02 johnbillion

Closing this in favour of #8585 which is more comprehensive. Thanks!

johnbillion avatar Jun 27 '25 17:06 johnbillion