John Blackbourn comments

Results 494 comments of


                                            John Blackbourn

#52217 - PHPStan config and fixes

https://core.trac.wordpress.org/changeset/51850

#52217 - PHPStan config and fixes

https://core.trac.wordpress.org/changeset/51851

`__return_null()` in `add_filter()` causes error

It's not intended, no.

We are not perfect: stubs problems

I think this is best addressed in WordPress core. A few of these have been reported already across a few tickets. See https://core.trac.wordpress.org/search?ticket=on&q=phpstan .

Add pluck/patch commands for caches and transients

What's left to do on this PR?

Since WordPress 6.5 deprecation warning related to `core/edit-post`

Thanks!

do_action ('qm/... never does anything

It looks like this, and other reports recently, essentially boil down to the possibility of infinite recursion when translation functions are called. There are a few places in QM where...

Enhance wp_hash function to support custom hashing algorithms

Committed in https://core.trac.wordpress.org/changeset/59578

Support beta/rc releases

If someone wants to take this over be my guest. See #17 for some more recent discussion and linked meta issues.

Also disable email sending

When I'm using an environment that doesn't have MailHog on it, I use a plugin such as https://wordpress.org/plugins/email-log/ to catch emails. Any change here would need to be tested with...