John Blackbourn
John Blackbourn
WP-CLI already has a command for this: https://developer.wordpress.org/cli/commands/term/recount/
Looks like the problem isn't confined to that file. Example: https://wpdirectory.net/search/01EXZCZ5E6GVYRY4YC8VCBM4SM (tenth result). `wp_normalize_path` is found within `wp-optimize.php` but not within `includes/backward-compatibility-functions.php` or `includes/class-updraft-smush-task.php`.
I haven't had time to continue working on this lately. Up until 69662ba this works nicely in Live Preview mode, but in cbe2484 I changed the appearance and hid it...
I'm trying to use the same approach as in the other workflows so we don't have too many different implementations of the same thing: https://github.com/WordPress/wordpress-develop/blob/trunk/.github/workflows/pull-request-comments.yml#L165
I think the permissions issue is due to this being a PR from a fork.
Moved the testing to https://github.com/johnbillion/wordpress-develop/pull/2
@Rajinsharwar @JJJ Any thoughts on what's up here? The `test_user_can_for_blog()` test is failing when it checks the `edit_posts` capability of a user on a site that the user doesn't belong...
https://core.trac.wordpress.org/changeset/59123
@hellofromtonya I've addressed your main concern about the impact of introducing static analysis in the comments on https://core.trac.wordpress.org/ticket/52217, but in short I don't believe that it introduces the sort of...
I'm going to update the description of this PR with notes about each change. I realise that it's not clear why quite a few of these changes have been made.