John Blackbourn

Results 494 comments of John Blackbourn

I've pushed a few commits to this PR to clarify the terminology in additional places and in particular to increase the distinction between permanent deletion. The phrase "Delete Permanently" is...

On my local machine I get an error when running `composer test` with this change: ``` find: -printf: unknown primary or operator ``` I can't see an advantage to this...

I covered that a bit in the FAQ. The main problem is that 72 bytes != 72 characters once you get outside of ASCII, and you'll need active warnings instead...

That's correct. Out of the PHP projects that I listed in the PR, only symfony/password-hasher includes any handling for passwords greater than 72 bytes, and even then it still truncates...

I've covered argon2 and scrypt in the PR description. Unfortunately there is not.

Again, I've covered this already in the PR description. sodium_compat still requires the optional libsodium extension in order to support argon2 or scrypt. There is no polyfill for either in...

TypeScript supports literal types, template literal types, and enums. I think a string pattern type is a natural extension that allows for non-finite value restrictions to be expressed. I'm writing...

Thanks! I've seen this myself and been trying to figure out why PHPStan isn't flagging it during the coding standards tests. I think I need to up the strictness of...

Ah no it's to do with the strict ruleset. https://github.com/phpstan/phpstan/discussions/11613. I'll get this fixed in the next release.

https://core.trac.wordpress.org/changeset/59203