John Blackbourn comments

Results 494 comments of


                                            John Blackbourn

Also disable email sending

Unfortunately I don't have time to look at this properly at the moment, but if a change is made here then IMO any existing plugin that catches emails should work...

Feature Request: Please address this plugin's conflicts with `php-stubs/wordpress-stubs`

Previously: #33

Unable to parse files that contain namespaces and variables passed by reference

@zackkatz Would you like to try version 1.0.0 to see if this has been fixed?

Unable to parse files that contain namespaces and variables passed by reference

Ok thanks! We should be in a better position to deal with it now though.

phpcs: use parallel mode

What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?

Make sure QM_Util::standard_dir is always called

Thanks for the PR! I'll take a look soon.

Add JSON schema for `wp-cli.yml`

It would be good to have some tests in place for this. I've used [ajv-cli](https://github.com/ajv-validator/ajv-cli) in several projects but it doesn't look like it supports YAML input. Maybe best done...

Tracking issue: Improve types for certain functions

`get_registered_settings()` and `get_post_type_capabilities()` were implemented in https://core.trac.wordpress.org/changeset/60236. The problem with declaring the shapes on class properties is it can lead to a load of duplication and we don't have a...

Tracking issue: Improve types for certain functions

https://core.trac.wordpress.org/ticket/57299 is probably relevant too, we don't yet know if the docs parser for developer.wordpress.org can handle array key notation. Needs somebody to volunteer to get that tested.

Request: Add notice with switch back link to Access Denied page in MultiSite

Thanks for the suggestion. I seem to remember that there are no useful hooks on that error screen, but I will take a look.