John Blackbourn comments

Results 494 comments of


                                            John Blackbourn

Add panel to display registered assets

I would like to get this in, but it's triggering a PHP warning on the front end. ``` Trying to access array offset on value of type null wp-includes/script-loader.php:2068 wp_style_loader_src()...

Add panel to display registered assets

My worry is whether this will result in errors for other third-party scripts and styles that are enqueued in the admin area and don't expect to be processed in the...

Fix Uncaught TypeError: parse_url(): Argument #1 () must be of type string, null given

Thanks for the PR, I'll take a proper look soon 👍

Fix Uncaught TypeError: parse_url(): Argument #1 () must be of type string, null given

Thanks for the PR @rebeccahum but I've decided not to merge this. The `url` element here ultimately comes from the `$url` parameter passed to the `wp_remote_*()` function, which expects a...

Check for root earlier

Is there a way to add tests for this that mock the return value of `posix_geteuid()`?

Introduce a dedicated `search-replace url` command

Related: https://github.com/wp-cli/ideas/issues/159

check if rows are countable

Thanks for the PR David! What can lead to this not being countable?

check if rows are countable

@davidsword Were you able to look into this any further? Any info you have could be helpful.

Added a 'raw' format to the option get command

I think I opened my original issue because `wp option list` allows you to see a raw value but `wp option get` does not. In an interactive terminal it's certainly...

Tests: Add Unit Tests for `wp_fast_hash()` Function

Thanks for the PR @Debarghya-Banerjee . Honestly I am in two minds about this, on one hand increased test coverage is always good, but on the other hand I don't...