John Blackbourn

Results 402 comments of John Blackbourn

This would be really handy for a project of mine. Any chance that this can go in?

They're about 90% from WP core, with some manual adjustments to increase the strictness and add extra constraints for PHPStan. I suppose we could use this Args library to generate...

Good idea. Any suggestions for how to make this distinction? I notice in your patch on https://core.trac.wordpress.org/attachment/ticket/48086/48086.diff the distinction is made in the name.

`sockets` is probably no longer required since Requests was merged in.

It turns out there is a core list: https://make.wordpress.org/hosting/handbook/handbook/server-environment/#php-extensions This list is used in `WP_Site_Health::get_test_php_extensions()` in the new Site Health functionality in 5.2, unfortunately not very well abstracted.

Fixed in 2.0.

Excellent point. On 14 Dec 2017 3:42 pm, "Daniel Bachhuber" wrote: > Because PHP supports two separate configurations, one for CLI and one for > web, it'd be helpful to...

Thanks. (The `wp_dropdown_categories` error in the coding standards check is unrelated to this change, I need to get that fixed.)

I forgot to say thanks for the PR. I won't have much time to look into this soon but I'll get to it when I can!

I need to check whether there's a chance this breaks other functionality that unintentionally passes an associative array of values, but generally I agree this change makes sense.