PHP 8.3 warning

Open knutsp opened this issue 1 year ago • 2 comments

PHP Warning: Increment on type bool has no effect, this will change in the next major version of PHP in */wp-crontrol/src/bootstrap.php on line 641

The variable $deleted contains the return value from Event\delete() and this method will return boolean true on success.

Oct 09 '24 23:10 knutsp

Thanks! I've seen this myself and been trying to figure out why PHPStan isn't flagging it during the coding standards tests. I think I need to up the strictness of its rules.

Oct 10 '24 00:10 johnbillion

Ah no it's to do with the strict ruleset. https://github.com/phpstan/phpstan/discussions/11613. I'll get this fixed in the next release.

Oct 10 '24 00:10 johnbillion