phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

phpcs: use parallel mode

Open janedbal opened this issue 2 years ago • 5 comments
trafficstars

Ideally, available vcpus should be used...

janedbal avatar Dec 05 '22 11:12 janedbal

What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?

johnbillion avatar Dec 09 '22 16:12 johnbillion

github actions run with 2 cores on the default instance. whether its a measurable difference need to be proved though.

staabm avatar Dec 09 '22 18:12 staabm

@theofidry maybe phpcs should have some cpu core autodetection ;)

staabm avatar Dec 09 '22 19:12 staabm

What improvement does this give?

Minor CI & local speedup.

maybe phpcs should have some cpu core autodetection ;)

Yeah, ideally. Current solution is really naive.


I dont really care about this PR much, but it feels wrong not to utilize faster solution :)

janedbal avatar Dec 12 '22 09:12 janedbal

@johnbillion

What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?

GH provides 2, 4, 8, 16, 64 core runners, also supports custom runners: https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners

I see this PR very beneficial - I can remove some custom core that I wrote to utility all CPUs for different tools

alies-dev avatar Dec 25 '22 22:12 alies-dev