John Blackbourn
John Blackbourn
There's a failing test: ``` 1) Tests_Cron::test_invalid_recurrence_for_event_returns_error sprintf(): Argument number must be greater than zero /var/www/src/wp-includes/cron.php:428 /var/www/tests/phpunit/tests/cron.php:856 phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:106 /var/www/vendor/bin/phpunit:118 ```
Maybe? I haven't had a need for it myself. Could be useful, but it would complicate the function signature as it wouldn't be able to support an associative array of...
Can we get test coverage added for the example CSS in the PR description?
@justlevine Thanks for all your work on this. * I think this is likely to get merged before the bump to PHP 7.4. I know it's a bit extra work...
I'll take a look!
@2ndkauboy I agree that introducing a `--format` parameter here is a good idea. Daniel left some good feedback and I agree with all his points. Is this something you'd like...
What's the command for that output?
I think `value` is better than `ID` but overall that table isn't particularly clear. Perhaps the order of the columns should change to: `column`, `match`, `key`, `value`. If we didn't...
Yeah. Perhaps `primary_key_name` and `primary_key_value`? It's very verbose but it's clear.
I ran some tests on a private repo using a workflow where the base permissions were set to `permissions: {}`. It seems that the only permission needed for uploading an...