Felix Exner (fexner)

Results 391 comments of Felix Exner (fexner)

I've implemented the changes as recapped in https://github.com/ros-industrial/universal_robot/pull/504#issuecomment-652448175 CI should accept this again and we can test this by rebasing #525 ontop of this. I am still not fully convinced...

As far as I understand gazebo inertia, no motor dynamics are included in this.

> Thanks for the answer. Do you see any chance in getting the motor dynamics into gazebo? This is out of scope of this PR. I am not sure whether...

> @fmauch could then rebase his branch and things would've worked out. I'd like to avoid rebasing the branch being used for the driver currently, as from my experience people...

in fact, after applying the requested changes, the two xacro files are almost identical except for the kr6 one using the legacy DEG2RAD conversion. I'll adapt the kr6 one then...

now, there is only one macro left shared by the kr6r900 and the kr10r900.

Hi there, I had a quick look again and I think all from the list has been integrated into the MR. However, the CI pipeline fails as it is being...

well, it is the kr6r900-file that fails. And that doesn't have the --inorder notation. I can change it there, as well.

> Is your `@fzi.de` address not associated with your GH account? The commits are showing up unattributed to @fmauch. I'll have to check that...

Yes, I might have to rewrite history... Thank you. On Donnerstag, 13. Dezember 2018 14:07:27 CET G.A. vd. Hoorn wrote: > > > Is your `@fzi.de` address not associated with...