Lennart Nachtigall
Lennart Nachtigall
@christophfroehlich Given that #139 is now merged I updated this PR. Please see my notes in the initial description about open points for discussion. Also pinging @saikishor
@christophfroehlich Just a note about the CI. Interestingly I just had the case that pre-commit in the CI failed but did run sucessfully on my system. (Note about using the...
> Strange. Have you run pre-commit run --all? otherwise it checks only the changed files in the index. Yes that's what I did run. But I couldn't reproduce it now....
The current implementation in the RealTimeBoxBestEffort basically disables the normal `trySet, tryGet...etc` methods for pointer types. Given that it is inherently unsafe to use pointers with this implemenation and the...
> Branch the rolling from others and then make this RealTimeBoxBestEffort as default over there. This introduces additional maintenance effort -> I can not judge if this would be worth...
@saikishor I just pushed a version which add a specialisation for pointer types. The tests will now show a deprecation note if get/set are used with pointer types. Also the...
@saikishor Perhaps you'll find some time for another review? It will now handle pointers types as before but print a deprecation warning
Just a friendly ping :)
If I understand the changes in #62 correctly then it is a good idea to not use the auto generated `joint_limits.yaml` from moveit. Additionally I guess I have to add...