Markus Elfring
Markus Elfring
I would like to point out that an identifier like “[`__TITANIA_X3D_H__`](https://github.com/create3000/titania/blob/f0f3a1ca054d901d92f5ea25a9d86eaeacede4ad/libtitania-x3d/Titania/X3D.h#L51 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the compiler implementation.") to the expected...
[Extra checks are not needed for a zero API handle](https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glDeleteProgram.xhtml "Description from the OpenGL reference") in [a function like “ComposedShader::set_loaded”](https://github.com/create3000/titania/blob/b555c2fea171fe2e0dadce9062a3c1d3ee33e92e/libtitania-x3d/Titania/X3D/Components/Shaders/ComposedShader.cpp#L145 "Update candidate").
I would like to point out that identifiers like “[`GFXPRIM_H__`](https://github.com/gfxprim/gfxprim/blob/46ac6a0beefaa6be34cb40924fffb5c31e27edc5/include/gfxprim.h#L9 "Update candidate")” and “[`x__`](https://github.com/gfxprim/gfxprim/blob/bc587b42ad922c933066c39fa138567888dd5472/include/widgets/gp_common.h#L12 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the...
[An extra null pointer check is not needed in a function](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like [the destructor for the class “Viewer”](https://github.com/baidu/ICE-BA/blob/c49560c81e47f6b52b18739194fef89330dbdfa0/Backend/Visualization/Viewer.h#L42 "Update candidate").
I would like to point out that identifiers like "[`__LAUNCH_H__`](https://github.com/rtyler/openlaunchd/blob/6bab361f2f168a13ddb400f8a2d3a4330e1676c6/liblaunch/launch.h#L21)" and "[`__VPROC_INTERNAL_H__`](https://github.com/rtyler/openlaunchd/blob/093fab18e15fe5830720a9f14faa639dc545a38f/liblaunch/vproc_internal.h#L21)" [do not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [MeasureMarker](https://github.com/cnr-isti-vclab/relight/blob/09d953ffcfc1383ea49684cb2a0d7b5fefd13fa8/relight/qmeasuremarker.cpp#L15) - [SphereMarker](https://github.com/cnr-isti-vclab/relight/blob/ff19708ca483239ada24149a7cdb1d112b3ebbf5/relight/qspheremarker.cpp#L31)
:thought_balloon: I find that include guards like “[`LP_H`](https://github.com/cnr-isti-vclab/relight/blob/b10cb3d759a3d31fcf6f283f9f8419d9858aa2ad/src/lp.h#L1)” and “[`RTI_H`](https://github.com/cnr-isti-vclab/relight/blob/b10cb3d759a3d31fcf6f283f9f8419d9858aa2ad/src/rti.h#L1)” are too short for the safe reuse of your header files (when they belong to an application programming interface).
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [Buffer::DeallocHost](https://github.com/PaddlePaddle/CINN/blob/85ab4981a38926dc5c1dbf672762cec335d2b857/cinn/runtime/buffer.h#L77 "Buffer::DeallocHost function") - [Shape::Resize](https://github.com/PaddlePaddle/CINN/blob/85ab4981a38926dc5c1dbf672762cec335d2b857/cinn/runtime/buffer.cc#L29 "Shape::Resize...
Some include guards do not fit to the expected naming convention of the C language standard. This detail can be fixed by the deletion of leading underscores. The probability for...
The configuration script "[AX_PTHREAD](http://www.gnu.org/software/autoconf-archive/ax_pthread.html)" should be added to the build specification so that corresponding special parameters will be taken into account.