Completion of error handling

[elfring]

Would you like to add more error handling for return values from functions like the following?

• pthread_mutex_init ⇒ critical_section_v4 constructor
• __itt_mutex_lock ⇒ fini_ittlib

[alexey-katranov]

It makes sense. Thank you for the report.

[anton-potapov]

critical_section was removed in oneTBB

[isaevil]

__itt_mutex_lock is now wrapped too at fini_ittlib.

[elfring]

:thinking: How does the mentioned “wrapping” improve the reported software situation?

[isaevil]

You are right, sorry. I didn't notice that return value handling is still unchanged. Notify @ekovanova. The return value is still unchecked for __itt_mutex_lock at https://github.com/intel/ittapi/blob/master/src/ittnotify/ittnotify_static.c#L139

[arunparkugan]

@isaevil is this issue still relevant?

[elfring]

How do you think about to improve static source code analysis also for this software? :thinking: