Markus Elfring
Markus Elfring
I would like to point out that identifiers like "[`_MOOSHIKA_H`](https://github.com/martinetd/mooshika/blob/7ff224dced50945251b4236fd4e3e5bdee155dfb/include/mooshika.h#L32)" and "[`_RMITM_H_`](https://github.com/martinetd/mooshika/blob/edf11d45fe94132a6cbbfb125d83516284dbd4d0/src/rmitm.h#L7)" [do eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to...
[An extra null pointer check is not needed in functions](http://dietmar-kuehl.de/mirror/c++-faq/freestore-mgmt.html#faq-16.8) like the following. - [destroy_tls_data](https://github.com/graphlab-code/graphlab/blob/6f787c7e351b6ed63e34db94fa754b515fd639f0/src/graphlab/parallel/pthread_tools.cpp#L97) - [omni_engine](https://github.com/graphlab-code/graphlab/blob/b04106c6234e3b513404af83a608cef866768643/src/graphlab/engine/omni_engine.hpp#L205) - [thrlocal_send_buffer_key_deleter](https://github.com/graphlab-code/graphlab/blob/734e9b6f9b93ebcbb88348671ede5bac25e7a353/src/graphlab/rpc/dc.cpp#L67) - [vid_vector](https://github.com/graphlab-code/graphlab/blob/b04106c6234e3b513404af83a608cef866768643/toolkits/graph_analytics/directed_triangle_count.cpp#L151)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
Would you like to replace [defines for constant values](https://github.com/ntpeters/SimpleLogger/blob/547828cf5e37b7fd1ea8d0ae2da2cfc582a1b11f/simplog.h#L19) by [enumerations](http://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages) to stress their relationships?
The functions "[fprintf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html)" and "[erase](http://linux.die.net/man/3/erase)" do not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/seccode/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[engine_safe_exit](https://github.com/alexdantas/yetris/blob/a40c5f3dff5a88c653b2c78b5327e17f44d1ad46/src/engine.c#L409)".
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I built the evolving network analysis tool according to the development revision “v0.95-17-g826ffa9”. I tried the program out then accordingly. ``` Sonne:/home/altes_Heim2/elfring/Projekte/Bau/mtr/console # ./mtr --report-cycles 5 --report --csv download.opensuse.org Mtr_Version,Start_Time,Status,Host,Hop,Ip,Loss%,Snt,...
I built the evolving network analysis tool according to the development revision “v0.95-17-g826ffa9”. I tried the program out then accordingly. ``` Sonne:/home/altes_Heim2/elfring/Projekte/Bau/mtr/console # ./mtr --report-cycles 5 --report download.opensuse.org Start: 2022-09-10T13:05:51+0200...
I noticed [the following loop in the implementation of the function “csv_close”](https://github.com/traviscross/mtr/blob/0886eee5bab164fee50f94d542de71fca8a2dc68/ui/report.c#L478 "Update candidate"). ```c for (i = 0; i < MAXFLD; i++) { j = ctl->fld_index[ctl->fld_active[i]]; if (j <...