Markus Elfring

Completion of error handling

2

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [intsetNew](https://github.com/loveyacper/Qedis/blob/464a8500c3d3f0f9b4b42f351566a07466e64049/QedisCore/redisIntset.c#L100) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [ziplistRepr](https://github.com/loveyacper/Qedis/blob/464a8500c3d3f0f9b4b42f351566a07466e64049/QedisCore/redisZipList.c#L913) -...

reserved identifier violation

2

I would like to point out that identifiers like “[`_HandlePacket`](https://github.com/loveyacper/Qedis/blob/3cc0e4a1ecc48bbc55958559b1953c270ff10b06/QSentinel/QClusterClient.h#L26)” and “[`__ziplistDelete`](https://github.com/loveyacper/Qedis/blob/464a8500c3d3f0f9b4b42f351566a07466e64049/QedisCore/redisZipList.c#L529)” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....

Remove unnecessary null pointer checks

11

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [NpcEdit::closeEvent](https://github.com/WohlSoft/PGE-Project/blob/e9305ad01b859090dfdd3bfc953b3478c3933f54/Editor/editing/edit_npc/npcedit.cpp#L56 "NpcEdit::closeEvent function") - [ScriptEditorWindow::setLang](https://github.com/WohlSoft/PGE-Project/blob/e44de8afde8f81a34eea27bba8ab145640482a59/Editor/main_window/script/script_editor.cpp#L115 "ScriptEditorWindow::setLang...

reserved identifier violation

1

I would like to point out that identifiers like “[`__AR_BASE_H__`](https://github.com/anyRTC-UseCase/SipRtcProxy/blob/8b416d374e25220009484b8cfe72a3f12c982303/include/ArBase.h#L6 "Update candidate")” and “[`__SIP_CALL_H__`](https://github.com/anyRTC-UseCase/SipRtcProxy/blob/8b416d374e25220009484b8cfe72a3f12c982303/include/SipCall.h#L1 "Another update candidate")” [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for...

Remove unnecessary null pointer checks

1

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [JsonStr](https://github.com/anyRTC-UseCase/SipRtcProxy/blob/694e512d233c0888ea0dd328706c9a6ae4d57b2f/include/rapidjson/json_str.h#L16 "Destructor for JsonStr") - [RtcCall](https://github.com/anyRTC-UseCase/SipRtcProxy/blob/a325057414b92dc07a3c1f99c2a9b851963c02be/src/RtcCall.cpp#L34...

Allocation error handling

6

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [interactive_next](https://github.com/emersion/mrsh/blob/eaf18a7e54797ec42929f370acafb8ab2a549e4e/frontend/readline.c#L30) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string.") ⇒ [mrsh_hashtable_set](https://github.com/emersion/mrsh/blob/442073258468d51704f72b33ba32d4b7be17227f/hashtable.c#L30)

Would you like to [add more error handling](https://github.com/ruben2020/codequery/blob/f5645c59031504d7a9c7db3c5fcb89d77129831d/makedb/csdbparser.cpp#L245 "Update candidate: csdbparser::open_file()") for return values from a function like “[fopen](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "Open a stream")”?

Addition of a build system generator

3

I suggest to reuse a higher level build system so that powerful checks for software features will become easier. - [CMake](https://cmake.org/ "Building software with CMake") - [Autotools](https://www.gnu.org/software/autoconf/autoconf.html#introduction "Building software with...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....