Markus Elfring

Results 791 issues of Markus Elfring

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [vkvg_create](https://github.com/jpbruyere/vkvg/blob/b983c8bce31bc86955a748e2f1304243f6e39cb9/src/vkvg_context.c#L34) - [realloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/realloc.html "Memory reallocation") ⇒ [_increase_font_tex_array](https://github.com/jpbruyere/vkvg/blob/b983c8bce31bc86955a748e2f1304243f6e39cb9/src/vkvg_fonts.c#L106)

enhancement

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [DensityOp](https://github.com/dreamworksanimation/openvdb/blob/18568814988362db3b6d661491a8179e6cec71de/openvdb_houdini/houdini/SOP_OpenVDB_Rasterize_Points.cc#L1547 "Destructor for DensityOp") - [OpFactory::setObsoleteParms](https://github.com/dreamworksanimation/openvdb/blob/a7a1abde7c955d5a83acac2c82341497d73576c2/openvdb_houdini/houdini/ParmFactory.cc#L1232)...

good first issue

I find the wording "[background thread](https://github.com/Kakadu/lablqt/blob/ebd270ff0dd5114f18a775520897c493bd16960f/qml/threads_test/README.md)" unusual. - Does it indicate any confusion with [background processes](https://en.wikipedia.org/wiki/Background_process)? - Would you like to express any other constraints for [the use of multi-threading...

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [BRepAlgoAPI_BuilderAlgo::Clear](https://github.com/tpaviot/oce/blob/bf969787b6e4ee81612d42e10d0e3f1633ed6b7b/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx#L75 "BRepAlgoAPI_BuilderAlgo::Clear function") - [LDOMParser](https://github.com/tpaviot/oce/blob/97611bd512083b23b84bee927e6b45684e910170/src/LDOM/LDOMParser.cxx#L40 "Destructor...

I suggest to reuse a higher level build system than [your small make script](https://github.com/mananapr/cfiles/blob/b6c08690bd065f08c6692e408820ece8ac26a8c4/Makefile#L1 "Update candidate") so that powerful checks for software features will become easier. - [CMake](https://cmake.org/ "Building software...

[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the function “FPlayerViewMode::SaveGameDefault”](https://github.com/unrealcv/unrealcv/blob/623d7c7df62e1442b79722b504ec869f8e6b118d/Source/UnrealCV/Private/PlayerViewMode.cpp#L195 "Update candidate: FPlayerViewMode::SaveGameDefault()").

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....

Would you like to [replace any double quotes](https://github.com/happyfish100/libshmcache/blob/e1dd2c55535cce1f471a211004a0a782f23ff9ca/src/shmcache.h#L12 "Check inclusion style") by [angle brackets around file names for include statements](https://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename "What is the difference between #include and #include “filename”?")?

I would like to point out that an identifier like “[`_SHMCACHE_H`](https://github.com/happyfish100/libshmcache/blob/e1dd2c55535cce1f471a211004a0a782f23ff9ca/src/shmcache.h#L3 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not use identifiers which are reserved for the compiler implementation.") to the...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....