Markus Elfring
Markus Elfring
Would you like to [wrap any pointers](https://github.com/PaddlePaddle/Anakin/blob/af7d12fe0a6d2fc25835b8e5080e3b8e22e23a52/framework/model_parser/parser/parser.cpp#L55 "Update candidate: load()") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
I would like to point out that an identifier like "[`_Op`](https://github.com/PaddlePaddle/Anakin/blob/931bf899166c627888d38372f00675b9d85b8d6d/framework/graph/node.h#L265 "Update candidate")" [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler implementation.") to the...
### Description :eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [RawAsset::UnloadInternal](https://github.com/Illation/ETEngine/blob/3fe039ff65cd1355957bcfce3f851fa411a86d94/Engine/source/EtCore/Content/Asset.inl#L13 "RawAsset::UnloadInternal function") - [Scene::SetStarfield](https://github.com/Illation/ETEngine/blob/def2fde461117bd0f513896ea54e2556490a8ee6/Engine/source/EtRendering/SceneStructure/RenderScene.cpp#L290 "Scene::SetStarfield...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
Would you like to wrap any pointer data members with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [ImportImageSeqDialog](https://github.com/pencil2d/pencil/blob/90e7164349d8d542bc2e96a546716ac5d9156883/app/src/importimageseqdialog.cpp#L35) - [RecentFileMenu](https://github.com/pencil2d/pencil/blob/9adb6170edccb608896b03fb8869a6d62a4bf261/core_lib/src/interface/recentfilemenu.cpp#L25)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
The function “[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html "Terminate a process.")” does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers "Call only asynchronous-safe functions within signal handlers."). I guess that a different program design will...
[Extra null pointer checks are not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [PolygonalCohesion](https://github.com/nepluno/libWetHair/blob/842444458657b796ed398be29534fa76f5aa2a51/libWetHair/Core/PolygonalCohesion.cpp#L147 "Destructor for PolygonalCohesion") - [WetHairCore](https://github.com/nepluno/libWetHair/blob/842444458657b796ed398be29534fa76f5aa2a51/libWetHair/Core/WetHairCore.cpp#L30 "Destructor...
I would like to point out that identifiers like “[`CAPSULE_H__`](https://github.com/nepluno/libWetHair/blob/842444458657b796ed398be29534fa76f5aa2a51/libWetHair/Core/Capsule.h#L13 "Update candidate")” and “[`__HAIR_FLOW_H__`](https://github.com/nepluno/libWetHair/blob/842444458657b796ed398be29534fa76f5aa2a51/libWetHair/Core/HairFlow.h#L14 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...